JuliaPackaging / BinaryBuilder.jl

Binary Dependency Builder for Julia
https://binarybuilder.org
Other
392 stars 101 forks source link

improve performance of instruction set checker #1140

Closed KristofferC closed 2 years ago

KristofferC commented 2 years ago

Running this on the product from OpenBlas in yggdrasil takes this part from

5.385089 seconds (48.11 M allocations: 4.965 GiB, 11.82% gc time)

to

1.505047 seconds (13.24 M allocations: 1.082 GiB, 8.13% gc time)

It is still not super significant because running the ´objdump` above takes like 15 seconds, but it is a start.

giordano commented 2 years ago

Nice to see there are some low-hanging fruits!

KristofferC commented 2 years ago

I think there are quite a lot of low hanging fruits. The next one is to read the output from objdump as it is being produced (concurrently) instead of waiting for it to finish before starting the string analysis.