JuliaPackaging / BinaryBuilder.jl

Binary Dependency Builder for Julia
https://binarybuilder.org
Other
392 stars 101 forks source link

Update dependencies for m1 #1168

Closed jeremiahpslewis closed 2 years ago

jeremiahpslewis commented 2 years ago

Update dependencies so that all support apple silicon.

In my tests, this should be sufficient to ensure M1 support via Docker, but perhaps there are edge cases not yet covered.

jeremiahpslewis commented 2 years ago

@giordano Can you correct my understanding, I'm modeling it off of https://github.com/JuliaPackaging/BinaryBuilder.jl/pull/1165, thought that once BB.jl has been updated, a PR to Yggdrasil like this one (https://github.com/JuliaPackaging/Yggdrasil/pull/4371) would ensure that these dependencies are used by the ci.

...but, now that I've written it out, it's clearly irrelevant for the CI seeing as users who install BinaryBuilder will pick up dependencies based on Project.toml and not Manifest.toml. Nonetheless, if there are unknown issues introduced by the new _jll builds (unrelated to M1 platform), we won't see them if we don't use it extensively, so not entirely a bad move?

giordano commented 2 years ago

The point of #1165 was to