search

JuliaPackaging / BinaryBuilder.jl

Binary Dependency Builder for Julia
https://binarybuilder.org
Other
384 stars 99 forks source link

Update `ObjectFile` dependency #1307

Closed eschnett closed 4 months ago

eschnett commented 6 months ago

BinaryBuilder.jl depends on ObjectFile = "0.3.6". This conflicts with Metal.jl which requires ObjectFile = "0.4". Could this dependency be updated? The latest version is 0.4.1.

giordano commented 6 months ago

There is #1277 already, but tests are broken and I don't know why. I don't know what changed in the ObjectFile package.

eschnett commented 6 months ago

@giordano How do I see which tests are broken? There doesn't seem to be any Github CI tests.

@staticfloat Do you know what changed in ObjectFile.jl between 0.3.7 and 0.4.1?

giordano commented 6 months ago

@giordano How do I see which tests are broken? There doesn't seem to be any Github CI tests.

I think I ran the tests locally.

giordano commented 6 months ago

I'm moderately sure it was https://github.com/staticfloat/ObjectFile.jl/pull/38 which broke it (the minor version number was bumped there), it changed the API of some commands, but never tracked how.

eschnett commented 4 months ago

Can we create a new release with the by-now updated ObjectFile dependency?

eschnett commented 4 months ago

@giordano Can we release a new version of this package?