search

JuliaPackaging / BinaryBuilder.jl

Binary Dependency Builder for Julia
https://binarybuilder.org
Other
384 stars 99 forks source link

Iterate over `readmeta` results #1308

Closed eschnett closed 5 months ago

eschnett commented 6 months ago

I couldn't run the test suite because

[13:48:09] ../meson.build:1:0: ERROR: Unable to detect linker for compiler `/opt/bin/x86_64-apple-darwin14-libgfortran4-cxx11-julia_version+1.7.3/x86_64-apple-darwin14-clang++ -Wl,--version -L/workspace/destdir/lib -fuse-ld=/opt/bin/x86_64-apple-darwin14-libgfortran4-cxx11-julia_version+1.7.3/x86_64-apple-darwin14-ld`
[13:48:09] stdout:
[13:48:09] stderr: ld: warning: directory not found for option '-L/workspace/destdir/lib'
[13:48:09] ld: unknown option: --version
[13:48:09] clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

That is, it fails because the Apple linkers aren't set up correctly. I think it's the same problem as https://github.com/JuliaPackaging/Yggdrasil/issues/7745.

eschnett commented 6 months ago

The meson build failure happens for me locally but not in CI.

giordano commented 6 months ago

We probably need to update BinaryBuilderBase first: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/6faea2ef758b089156f35716d0f55dc74a8ab786/test/Project.toml#L16

eschnett commented 6 months ago

This PR depends on https://github.com/JuliaPackaging/BinaryBuilderBase.jl/pull/363.

eschnett commented 6 months ago

This PR probably needs to disable ObjectFile 0.3. Should I do this, or should I add a function with a @static if condition to handle both versions?

giordano commented 6 months ago

Only v0.4 is fine

eschnett commented 6 months ago

It seems Manifest.toml is committed into the repository. Should I updated it as well? Or should I remove it?

giordano commented 5 months ago

I'm not a fan of committing the Manifest in packages, but let's update it for the time being.