JuliaPackaging / BinaryBuilderBase.jl

https://juliapackaging.github.io/BinaryBuilderBase.jl/stable
MIT License
11 stars 31 forks source link

[Dependency] Preserve `top_level` when converting `RuntimeDependency` -> `Dependency` #304

Closed giordano closed 1 year ago

giordano commented 1 year ago

First part of fixing https://github.com/JuliaPackaging/Yggdrasil/pull/6417#issuecomment-1476823499.

This was quite a yak-shaving, because while preparing the test I double checked that that new tests would fail without the change introduced here, which of course didn't happen, and realised that the current definition of == for AbstractDependency wasn't really sound.

Note: https://github.com/JuliaPackaging/BinaryBuilder.jl/pull/1273 reduces the need for such conversions, but doesn't entirely eliminate it. I think it'd be better to try and avoid the conversion completely at a later point.