Closed cserteGT3 closed 8 months ago
Sorry for the late review!
I think the problem is, that ther folder where git wants to check out doesn't exist
I don't think this is an accurate analysis. The output you shared shows the message Using cached git repository
which comes from https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/6faea2ef758b089156f35716d0f55dc74a8ab786/src/Sources.jl#L212 which is in a different if
branch than what you're editing in this PR, so I don't see how this PR would fix that issue.
Side note, I'm even surprised that BinaryBuilder works at all on Windows, to the best of my knowledge it shouldn't work, see for example https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/25 and https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/520
If I remember correctly, the PR fixed my issue, but it was long time ago, and I abandoned the project since then. I suggest closing this PR.
Thank you for taking your time to review it!
I was testing the resurrected MuJoCo jll build (PR here: https://github.com/JuliaPackaging/Yggdrasil/pull/7119), and errors like this ocurred:
I think the problem is, that ther folder where git wants to check out doesn't exist, therefore the cloning fails. This PR fixes is, by checking if the parent directory of the
repo_path
exists and creating it if not.Let me know what you think about this