JuliaPackaging / BinaryBuilderBase.jl

https://juliapackaging.github.io/BinaryBuilderBase.jl/stable
MIT License
11 stars 31 forks source link

Don't override authentication callbacks in libgit2 clone #319

Closed Keno closed 11 months ago

Keno commented 1 year ago

Use the supported callbacks interface rather than trying to re-do the low level interface. As reported in https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/1287, we currently try to error when attempting to clone a repository over ssh (either directly or via the insteadOf git setting), because we accidentally override the base callback to provide ssh credentials.

Fixes https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/1287