search

JuliaPackaging / BinaryBuilderBase.jl

https://juliapackaging.github.io/BinaryBuilderBase.jl/stable
MIT License
11 stars 31 forks source link

[Runner] Make `clang_use_lld` a keyword argument #357

Closed giordano closed 8 months ago

giordano commented 8 months ago

I need to do more testing (hence opening as draft), but this might be sufficient to let users set clang_use_lld as keyword argument to BinaryBuilder.build_tarballs, so that they can easily opt-out of it.

giordano commented 8 months ago

Ok, I confirm the change I proposed in this PR is indeed enough here in BinaryBuilderBase, but we need another small change in BinaryBuilder so that we can use the new keyword argument in BinaryBuilder.build_tarballs. Edit: https://github.com/JuliaPackaging/BinaryBuilder.jl/pull/1310.

giordano commented 8 months ago

The test failure on nightly is unrelated to this PR and it's caused by this new warning being printed by Pkg:

┌ Warning: Circular dependency detected. Precompilation will be skipped for:
│   Downloads [f43a241f-c20a-4ad4-852c-f6b1247861c6]
│   Pkg [44cfe95a-1eb2-52ea-b672-e2afdf69b78f]
│   p7zip_jll [3f19e933-33d8-53b3-aaab-bd5110c3b7a0]
│   MozillaCACerts_jll [14a3606d-f60d-562e-9121-12d972cd8159]
│   LibCURL [b27032c2-a3e7-50c8-80cd-2d36dbcbfd21]
└ @ Pkg.API ~/repo/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:1260

This CI job back on November 29th 2023 was successful.