search

JuliaPackaging / BinaryBuilderBase.jl

https://juliapackaging.github.io/BinaryBuilderBase.jl/stable
MIT License
11 stars 31 forks source link

Add riscv64 PlatformSupport #374

Open eschnett opened 4 months ago

giordano commented 4 months ago

What's the corresponding PR to Yggdrasil?

eschnett commented 4 months ago

That's a complicated story... Adding a new architecture requires patches to BinaryBuilderBase, BinaryBuilder, and Julia itself. I'm building Yggdrasil packages with Julia 1.7, and it doesn't seem viable to have patches against it accepted.

At the moment this is just a test balloon to support RISC-V as a new architecture in general.

I think I'll start by opening a PR against Julia's master branch.

giordano commented 4 months ago

Ok, yeah, my next comment was going to be that it'll be complicated to have this going on with current incarnation of BinaryBuilder given adding new architectures/OSes requires changing in Julia, but we're currently stuck with Julia v1.7. https://github.com/JuliaPackaging/BinaryBuilder2.jl should improve the situation going forward, but we are definitely not there yet. But please do start with contributing changes to julia!

eschnett commented 4 months ago

The BinaryBuilder PR https://github.com/JuliaPackaging/BinaryBuilder.jl/pull/1321.

eschnett commented 4 months ago

The BinaryBuilderBase PR: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/pull/375

eschnett commented 4 months ago

The Yggdrasil PR: https://github.com/JuliaPackaging/Yggdrasil/pull/8468

eschnett commented 4 months ago

And the PR for Julia itself: https://github.com/JuliaLang/julia/pull/54011

oscardssmith commented 3 months ago

Now that the julia side is merged, is this ready?

giordano commented 3 months ago

That's really not that easy. BinaryBuilder only works with julia v1.7, so the changes in Julia v1.12 won't help. I think whatever changes we need to do on this side will have to wait for BinaryBuilder2

eschnett commented 3 months ago

I have made corresponding changes to Julia 1.7. We could (i.e., I will have to) maintain a feature branch. This will allow us to go forward in the short term, and we can then merge some changes into BinaryBuilder, BinaryBuilderBase, and the Yggdrasil base image (or respective feature branches...)