JuliaPackaging / Requires.jl

Lazy code loading for Julia
Other
195 stars 28 forks source link

Issue notifications after loading package #106

Closed timholy closed 2 years ago

timholy commented 2 years ago

Other packages can set up callbacks to be notified about @require blocks. Previously, the notification was issued before Requires set the const for the module name in the package that set up the @require block. This PR changes it so that those notifications are sent afterwards, thus ensuring that the const will be defined by the time "consumers" get notified.

This is a potentially-breaking change. Since it would cause huge [compat] churn to bump the major version, given the considerations below I think we can safely use a minor-version bump:

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7ff79f6). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #106   +/-   ##
=========================================
  Coverage          ?   62.66%           
=========================================
  Files             ?        3           
  Lines             ?       75           
  Branches          ?        0           
=========================================
  Hits              ?       47           
  Misses            ?       28           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ff79f6...4c301db. Read the comment docs.

timholy commented 2 years ago

Given that I see a thumbs-up for @KristofferC, and I doubt anyone else will review this, let's do it and release a new version.