search

JuliaPackaging / Scratch.jl

Scratch spaces for all your persistent mutable data needs
MIT License
58 stars 11 forks source link

Widen version compat #24

Closed MichaelHatherly closed 3 years ago

MichaelHatherly commented 3 years ago

Fixes #22. It seems all that was needed was to check for existence of active_project since it was returning an invalid path for Julia 1.0-1.2, not sure why though. Locally all tests were passing, but we'll see what travis thinks...

Bit of a hack to handle the io keyword for Julia below 1.4, alternative suggestions welcome.

codecov[bot] commented 3 years ago

Codecov Report

Merging #24 (7cb0686) into master (2b527ef) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 7cb0686 differs from pull request most recent head 8d2b378. Consider uploading reports for the commit 8d2b378 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files           1        1           
  Lines          90       90           
=======================================
  Hits           76       76           
  Misses         14       14
Impacted Files Coverage Δ
src/Scratch.jl 84.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b527ef...8d2b378. Read the comment docs.

MichaelHatherly commented 3 years ago

The failures on 1.7 for win and mac don't appear related and are present for me locally on 1.7 with both win and mac.