search

JuliaPackaging / Scratch.jl

Scratch spaces for all your persistent mutable data needs
MIT License
58 stars 11 forks source link

Small tweaks to allow Julia 1.5. #5

Closed fredrikekre closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files           1        1           
  Lines          69       69           
=======================================
  Hits           42       42           
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b43becc...add95b1. Read the comment docs.

staticfloat commented 3 years ago

I'm only 40% convinced that we should even allow people to use this on 1.5. I don't think it should be legal to run this without the ability to GC.

fredrikekre commented 3 years ago

You can still gc by using 1.6 though?

staticfloat commented 3 years ago

True, although there's still the possibility that some users will stay on 1.5 for a while.

I suppose it gives us an on-ramp to get people upgraded to 1.6. :) "Move to 1.6 and it'll actually save you disk space!". ;)

fredrikekre commented 3 years ago

I was mostly annoyed that I always accidentally started 1.5 when testing :) And also that it might be nice with some beta-testing. We could also implement some basic GC as Scratch.gc() I guess.