search

JuliaParallel / ClusterManagers.jl

Other
232 stars 74 forks source link

Fix SlurmManager launch #199

Closed oschulz closed 2 months ago

oschulz commented 2 months ago

Using append! for job_output_template appends it character-wise, causing failure. Need to use push!.

kescobo commented 2 months ago

Is there a compelling reason to merge this before #200, rather than just closing this and merging the other?

oschulz commented 2 months ago

Thanks @kescobo and @Moelf ! The test failures are unrelated, I think.

oschulz commented 2 months ago

Is there a compelling reason to merge this before #200, rather than just closing this and merging the other?

No, I just wanted to keep the little fix and the improvements separate for review purposes.

Closing this since included in #200.

kescobo commented 2 months ago

Yeah, testing is not in a great state right now. #105