Open jpsamaroo opened 3 years ago
Changing my mind about this after getting multi-GPU with DaggerGPU to work properly: we should always wrap inputs in a Chunk
, potentially with the option to opt-out, because we don't know if the value can be serialized.
In #199 I've fixed a "bug" where non-thunk inputs are serialized during the thunk RPC call, which is silly for large inputs. That fix assumes that inputs are large enough to wrap in a Chunk, which is not always true. It also re-wraps inputs in Chunks multiple times, which can incur extra overhead. We should make a dynamic decision whether to wrap in a Chunk, and if we wrap, wrap just once.