JuliaParallel / Dagger.jl

A framework for out-of-core and parallel execution
Other
621 stars 67 forks source link

Fix `mapchunks` and write Test for it #476

Open schlichtanders opened 5 months ago

schlichtanders commented 5 months ago

While looking for a way to flatten an DArray, I found mapchunks, which looks perfectly suited for this job. Unfortunately it is currently buggy. Probably because there is no test for it.

https://github.com/JuliaParallel/Dagger.jl/blob/cec17a14f75523bdcae3a6b00ede6c22d1d0fe9f/src/array/darray.jl#L387-L393

The DArray constructor used here does not exist any longer. There is a new argument - the partitioning - which need to be added.

- DArray{T,N,F}(d.domain, d.subdomains, chunks, d.concat) 
+ DArray{T,N}(d.domain, d.subdomains, chunks, d.partitioning, d.concat) 
schlichtanders commented 5 months ago

Furthermore, it would be great if