Closed JamesWrigley closed 5 months ago
I think this should be fixed in 73c62dc, where I changed the code to use Base.promote_op()
. I'm not an expert with that part of Julia though so I may be mistaken.
Thanks, this avoids the heartburn I feel when using Base._return_type
:smile:
A lot of tests failed when I was running them locally because that variable is defined in the
Dagger
module rather thanDagger.Sch
. Though a lot still fail for me with this error:I think we're running into https://github.com/JuliaLang/julia/issues/52385 :grimacing: I'll try to look into that in a few days.
(P.S.: I configured the PR to merge into #463 instead of
master
)