search

JuliaParallel / Dagger.jl

A framework for out-of-core and parallel execution
Other
621 stars 67 forks source link

Stop tracking the manifest files #487

Closed JamesWrigley closed 5 months ago

JamesWrigley commented 5 months ago

I don't think these really need to be tracked, and they cause conflicts whenever the manifest is changed and you switch branch or something.

jpsamaroo commented 5 months ago

This generally LGTM - do you know why the docs build is failing? Maybe the default settings changed upstream? We need to be able to skip some of these missing doc checks until we get that fully fixed up.

JamesWrigley commented 5 months ago

Ahh yes, that'll be because #482 is fixed now that ProfileSVG.jl has been updated, so now the docs will be using Documenter.jl v1 which has stricter defaults. I'll update the docs :)

JamesWrigley commented 5 months ago

Fixed in 518a4b0 and 85df3cb, so this should fix #482 too now.

JamesWrigley commented 5 months ago

A bunch of other jobs are still broken, but I don't think that's caused by the manifest being deleted, and it should be working in #463, sooooo I don't think I'll bother fixing that :see_no_evil:

jpsamaroo commented 5 months ago

Thanks!

Yes those jobs were previously failing, but I haven't had the chance to look into them.