JuliaParallel / Dagger.jl

A framework for out-of-core and parallel execution
Other
621 stars 67 forks source link

Fix import of ScopedValues in Julia v1.11 #489

Closed JamesWrigley closed 5 months ago

JamesWrigley commented 5 months ago

Previously ScopedValues.with was exported from Base but that was changed recently, so the ScopedValues check was failing. Now we check if the module is present instead.

Should fix #488. I still this warning when running the tests:

┌ ScopedValues                                                                                                                                                                                                                                 
│  WARNING: could not import ScopedValues.current_scope into ScopedValues                                                                                                                                                                      
└    

But we don't use current_scope() anywhere so I assume it's coming from Base :shrug:

jpsamaroo commented 5 months ago

Thanks!