search

JuliaParallel / Dagger.jl

A framework for out-of-core and parallel execution
Other
610 stars 66 forks source link

Rename EagerThunk to DTask #518

Closed jpsamaroo closed 1 month ago

jpsamaroo commented 1 month ago

EagerThunk is a terrible name - let's change this to something a bit more easily explainable. Also adds a better docstring for Dagger.@spawn to help explain how it differs from Julia's Task.

Also deprecates delayed - this API is no longer recommended for various reasons, and will be removed as a user-facing API in the future.

JamesWrigley commented 1 month ago

The array allocation test failure on 1.10 is a little concerning :thinking: Is this the first time it happened or is that just a flaky test?

jpsamaroo commented 1 month ago

The array allocation test failure on 1.10 is a little concerning 🤔 Is this the first time it happened or is that just a flaky test?

Just a flaky test! I guess it's possible to get 0 from rand() - I should probably test that there are less than 5% of zeros or something like that.