JuliaParallel / Dagger.jl

A framework for out-of-core and parallel execution
Other
638 stars 67 forks source link

Replace all uses of @async with Threads.@spawn #559

Closed JamesWrigley closed 2 months ago

JamesWrigley commented 3 months ago

- Use errormonitor_tracked() for executing DTask's - Set allow_errors=false by default in the eager scheduler.

I don't know why we had allow_errors=true originally but it seems way too permissive, it caused some internal exceptions to not be logged when I was working on the streaming branch.

JamesWrigley commented 3 months ago

In hindsight I should've run the tests locally first :laughing: I'll try to fix those errors.

JamesWrigley commented 2 months ago

Using errormonitor_tracked() would still print out some ugly error messages when I don't think we want it to so I decided to revert that, now the only change is to use Threads.@spawn everywhere instead of @async.

jpsamaroo commented 2 months ago

Thanks!