Closed vchuravy closed 6 years ago
Breadcrumb for myself. In the CuArray case we are calling a gpu kernel with DArray{CuArray}
... So we might want to contrain ourselves to situations where the localparts match up...
I will merge this for now. Test for CuArrays and DArrays live at https://github.com/vchuravy/Heterogeneous.jl and the (minimal) tests passed successfully https://gitlab.com/JuliaGPU/Heterogeneous.jl/-/jobs/99040385. I will squash and merge this.
This PR has two goals. First and foremost it makes
broadcast
generally work forDArrays
didn't work before. Secondly it tries to be aware of the fact that we can have an underlying ArrayType that is not
Array
and which provides its own Broadcast implementation and customisation.Currently the following didn't work yet:
because we apparently short-circuit the broadcast customisation of CuArray that does the function translation.
cc: @maleadt