Proposal for modifications to reshapelocalarray

JuliaParallel / PETSc.jl

Julia wrappers for the PETSc library

Other

121 stars 38 forks source link

Proposal for modifications to reshapelocalarray #169

Closed jkozdon closed 3 years ago

jkozdon commented 3 years ago

Have getlocalcoordinatearray return a 4-D array with fastest being dimension followed by point
Remove getlocalarraydof
Introduce withreshapelocalarray! which is like withreshapelocalarray! but adds a call to reshapelocalarray so and properly finalizes the unsafe_localarray wrapping

Something to address: we need to finalize the getlocalcoordinatearray so a call to VecRestoreArrayRead occurs, and I am not sure the best way to do this

jkozdon commented 3 years ago

@boriskaus I think that I am good with this. Let me know your thoughts and / or feel free to merge.

Next week I can cleanup #168 and merge it in (about to head out of town for the weekend).

boriskaus commented 3 years ago

thanks!