search

JuliaPerf / BenchmarksGame.jl

Other
43 stars 13 forks source link

fix type issues #27

Closed hycakir closed 5 years ago

hycakir commented 5 years ago

This should give slightly better performance. Makes Perm.count an Int32 array again (I had made it an Int8 array, by mistake).

KristofferC commented 5 years ago

Thanks, looks like this has to be rebased on the master branch on this repo.

hycakir commented 5 years ago

I thought there would be no conflict, since the last commit for this file was also on my repo. I do not know Git much. Should I fetch your repo and then create a PR again?

KristofferC commented 5 years ago

You can rebase on origin/master after a git fetch and fix up the merge conflict.