JuliaPerf / MCAnalyzer.jl

A set of tools for machine code analyzing of Julia code
Other
46 stars 9 forks source link

Bump GPUCompiler dependency #26

Closed Seelengrab closed 2 years ago

Seelengrab commented 2 years ago

Ok, I think this should be it! Not 100% sure if the changes are correct, I basically just followed the stuff I did for getting the arduino code to work. Closes #25

I guess I could bump LLVM as well? What's the policy on that, keeping current with what julia ships or is something newer ok too?

vchuravy commented 2 years ago

probalby we can bump that as well and then drop some of the older crud

Seelengrab commented 2 years ago

Hmm, just adding 14 to the [compat] section doesn't actually allow me to download LLVM_jll version 14 :thinking: Pkg even says that the new version is available, doesn't want to download it though and isn't even helpful when trying to force it:

(MCAnalyzer) pkg> add LLVM_jll@v14.0.2
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package libLLVM_jll [8f36deef]:
 libLLVM_jll [8f36deef] log:
 ├─possible versions are: 13.0.1 or uninstalled
 └─found to have no compatible versions left with LLVM_jll [86de99a1]
   └─LLVM_jll [86de99a1] log:
     ├─possible versions are: 6.0.1-14.0.2 or uninstalled
     ├─restricted to versions [9, 11-14] by MCAnalyzer [a81df072], leaving only versions 9.0.1-14.0.2
     │ └─MCAnalyzer [a81df072] log:
     │   ├─possible versions are: 0.3.3 or uninstalled
     │   └─MCAnalyzer [a81df072] is fixed to version 0.3.3
     └─restricted to versions 14.0.2 by an explicit requirement, leaving only versions 14.0.2

even though that version exists https://juliahub.com/ui/Packages/libLLVM_jll/BYxGh/14.0.2+0

and adding it explicitly adds v13.0.1?!

(MCAnalyzer) pkg> add libLLVM_jll@v14.0.2
   Resolving package versions...
    Updating `~/Documents/projects/MCAnalyzer.jl/Project.toml`
  [8f36deef] + libLLVM_jll v13.0.1+0
  No Changes to `~/Documents/projects/MCAnalyzer.jl/Manifest.toml`
Seelengrab commented 2 years ago

If you're fine with just bumping GPUCompiler, this should be good to merge imo - LLVM 13 makes it work for my use cases.

Seelengrab commented 2 years ago

Do we have tagbot for tagging a release as well?

vchuravy commented 2 years ago

Already done

Seelengrab commented 2 years ago

Huh, then I think something doesn't work correctly, since it doesn't show up in https://github.com/JuliaPerf/MCAnalyzer.jl/releases