search

JuliaPerf / PProf.jl

Export Julia profiles to the pprof format
MIT License
155 stars 18 forks source link

Add optional `lidict` param to `pprof()` to support exported Profile data #26

Closed NHDaly closed 4 years ago

NHDaly commented 4 years ago

From the Profile docs: https://docs.julialang.org/en/v1/stdlib/Profile/#Profile.retrieve

"Exports" profiling results in a portable format, returning the set of all backtraces (data) and a dictionary that maps the (session-specific) instruction pointers in data to LineInfo values that store the file name, function name, and line number. This function allows you to save profiling results for future analysis.

You need both data and linfo to reuse a profile from a different process, and we currently don't support passing in the linfo.

So this PR fixes that.

Sacha0 commented 4 years ago

Build failures appear confined to a small subset of macOS nightly tests. Not sure whether those failures are expected?

Sacha0 commented 4 years ago

(Looks like CI failures remain confined to the same subset of macOS nightly tests.)

NHDaly commented 4 years ago

Oh, whoops. Forgot to release this!

Is this a 1.2.0 or 2.0.0? Since we're technically making a breaking change the API (moved period positional arg to sampling_delay= keyword arg). But i dunno if anyone was using that anyway?

I don't mind tagging 2.0.0 i don't think! :)