search

JuliaPerf / PProf.jl

Export Julia profiles to the pprof format
MIT License
155 stars 17 forks source link

Support Metadata like Threadid #40

Closed vchuravy closed 8 months ago

NHDaly commented 2 years ago

Cool, what's meta?

vchuravy commented 2 years ago

metadata like threadid

NHDaly commented 9 months ago

Omg wow, ~literally one year later~

OMG no - TWO YEARS LATER! Yikes

codecov[bot] commented 9 months ago

Codecov Report

Merging #40 (f8f1de9) into main (6e9f56c) will increase coverage by 0.24%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   96.66%   96.91%   +0.24%     
==========================================
  Files           3        3              
  Lines         300      324      +24     
==========================================
+ Hits          290      314      +24     
  Misses         10       10
Files Coverage Δ
src/PProf.jl 99.32% <100.00%> (+0.13%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

NHDaly commented 9 months ago

It seems that the tests are broken on ubuntu, even on master. I'm inclined to merge this and deal with the broken tests later. Tests pass locally for me. :)