search

JuliaPerf / PProf.jl

Export Julia profiles to the pprof format
MIT License
155 stars 17 forks source link

Revert "CompatHelper: bump compat for ProtoBuf to 0.11, (keep existing compat)" #43

Closed NHDaly closed 2 years ago

NHDaly commented 2 years ago

Reverts JuliaPerf/PProf.jl#42

Until we adapt to the changes in the Proto.jl package.

NHDaly commented 2 years ago

Huh, looks like we also have problems with julia 1.0:

ERROR: LoadError: Unable to import pprof_jll on Julia versions older than 1.3!

https://github.com/JuliaPerf/PProf.jl/runs/4638518767?check_suite_focus=true

🤔 oops - compat is hard

codecov-commenter commented 2 years ago

Codecov Report

Merging #43 (160c9a8) into master (2693fb4) will decrease coverage by 1.36%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.18%   96.81%   -1.37%     
==========================================
  Files           2        2              
  Lines         220      220              
==========================================
- Hits          216      213       -3     
- Misses          4        7       +3
Impacted Files Coverage Δ
src/PProf.jl 96.69% <0.00%> (-2.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5872757...160c9a8. Read the comment docs.