search

JuliaPerf / PProf.jl

Export Julia profiles to the pprof format
MIT License
155 stars 17 forks source link

Add support for the Allocs profiles produced by Julia's Allocs Profiler #46

Closed NHDaly closed 2 years ago

NHDaly commented 2 years ago

Add support for the Allocs profiles produced by Julia's Allocs Profiler

Support for visualizing the results from the allocations profiler in draft PR: JuliaLang/julia#42768.

This was basically copy/pasted from https://github.com/vilterp/AllocProfileParser.jl.

Screen Shot 2022-01-03 at 9 50 41 PM Screen Shot 2022-01-03 at 9 45 39 PM
codecov-commenter commented 2 years ago

Codecov Report

Merging #46 (be54421) into master (eaadf51) will decrease coverage by 1.82%. The diff coverage is 91.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   98.22%   96.39%   -1.83%     
==========================================
  Files           2        3       +1     
  Lines         225      305      +80     
==========================================
+ Hits          221      294      +73     
- Misses          4       11       +7
Impacted Files Coverage Δ
src/PProf.jl 99.19% <ø> (ø)
src/Allocs.jl 91.25% <91.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaadf51...be54421. Read the comment docs.

vchuravy commented 2 years ago

Now that this has landed in Base we should land this

NHDaly commented 2 years ago

Agreed. Just made some fixups to the API; this is ready to go now!

NHDaly commented 2 years ago

Cool! Thanks all - merging now

NHDaly commented 2 years ago

(leaving the branch up for anyone who had pointed their PProf at it locally)