JuliaPerf / PProf.jl

Export Julia profiles to the pprof format
MIT License
154 stars 17 forks source link

Exclude new metadata from profiler on 1.8+ #59

Closed IanButterworth closed 2 years ago

IanButterworth commented 2 years ago

The metadata occupies samples so needs to be excluded if you're not handling it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #59 (6edde99) into master (34c8724) will increase coverage by 23.94%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
+ Coverage   72.51%   96.46%   +23.94%     
===========================================
  Files           3        3               
  Lines         302      311        +9     
===========================================
+ Hits          219      300       +81     
+ Misses         83       11       -72     
Impacted Files Coverage Δ
src/PProf.jl 99.23% <100.00%> (+0.03%) :arrow_up:
src/flamegraphs.jl 97.02% <0.00%> (+0.06%) :arrow_up:
src/Allocs.jl 91.25% <0.00%> (+91.25%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

vchuravy commented 2 years ago

See #40 as well