search

JuliaPerf / PProf.jl

Export Julia profiles to the pprof format
MIT License
154 stars 17 forks source link

Show the metadata tags in the flamegraph UI by default #91

Open NHDaly opened 8 months ago

NHDaly commented 8 months ago

Add an option to show the metadata tags in the flamegraph view, as root nodes, like this:

Screenshot 2023-10-20 at 4 57 49 PM

I don't love that the tags aren't labelled..... I've asked about that here: https://github.com/google/pprof/issues/811

I'm also not sure if tagroot= is the right way to expose this. Maybe it should be higher-level, like metadata::Bool and we just add this? Or groupby=["taskid", "threadid"], and we turn that into tagroots?

codecov[bot] commented 8 months ago

Codecov Report

Merging #91 (c2ec74d) into vc/tags (2a789ae) will decrease coverage by 0.60%. Report is 1 commits behind head on vc/tags. The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           vc/tags      #91      +/-   ##
===========================================
- Coverage    96.60%   96.01%   -0.60%     
===========================================
  Files            3        3              
  Lines          324      326       +2     
===========================================
  Hits           313      313              
- Misses          11       13       +2
Files Coverage Δ
src/PProf.jl 98.00% <75.00%> (-0.65%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more