JuliaPhysics / PeriodicTable.jl

Periodic Table for Julians! :fire:
Other
111 stars 26 forks source link

Julia 1.0 support: new iterator interface #16

Closed carstenbauer closed 6 years ago

carstenbauer commented 6 years ago

This PR adds support for the new iterator interface to make the package work in Julia 1.0.

carstenbauer commented 6 years ago

I suggest tagging a new release after this has been merged to make the package function in 1.0.

rahulkp220 commented 6 years ago

Thanks for the PR @crstnbr , Can you also update the REQUIRE file too?

carstenbauer commented 6 years ago

What update do you have in mind?

Currently it contains julia 0.6 which should include all Julia versions >= 0.6, which seems fine to me (Note that I didn't remove the old iterator interface implementation).

rahulkp220 commented 6 years ago

I was thinking to upgrade it to Julia 0.7, which would then take it to the next stage easily with 1.0. I guess the tests were already fixed for deprecations in an earlier PR

carstenbauer commented 6 years ago

So you want to drop 0.6 support? If so, I should delete the old iterator interface (and version based branch), which is only needed for julia < 0.7.

rahulkp220 commented 6 years ago

Hmm, let's leave it there. I wished to go post 0.7, but I guess, its okay for some time to have 0.6 supported. I agree with your initial comment on keeping it at 0.6.

Also, I have sent an invite for you to become a collaborator :)

carstenbauer commented 6 years ago

Ok, thanks! I'll finish this up (will add some iterator test).

codecov-io commented 6 years ago

Codecov Report

Merging #16 into master will increase coverage by 5.12%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #16      +/-   ##
========================================
+ Coverage   94.87%   100%   +5.12%     
========================================
  Files           1      1              
  Lines          78     51      -27     
========================================
- Hits           74     51      -23     
+ Misses          4      0       -4
Impacted Files Coverage Δ
src/PeriodicTable.jl 100% <100%> (+5.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c970b79...8bf0408. Read the comment docs.

carstenbauer commented 6 years ago

v1.0 CI failures are due to Pkg not defined. This will be a reason to drop 0.6 at some point. I'll rebase and merge.

rahulkp220 commented 6 years ago

Yeah, I guess a move to 0.7 will be inevitable very soon.

carstenbauer commented 6 years ago

Could you tag a new release such that 1.0 users will be able to use the package?

rahulkp220 commented 6 years ago

For any new release, just draft a new one and attobot will take care of the rest :) Anyways, you can track it here https://github.com/JuliaLang/METADATA.jl/pull/17855