search

JuliaPhysics / PeriodicTable.jl

Periodic Table for Julians! :fire:
Other
111 stars 26 forks source link

Dimensionful quantities with Unitful.jl #19

Closed carstenbauer closed 6 years ago

carstenbauer commented 6 years ago

See #7.

I left the custom unit output as I think J/mol K is nicer than J mol^-1 K^-1.

One could also make this an upstream issue in Unitful.jl and improve the printing of units (https://github.com/ajkeller34/Unitful.jl/issues/18 is similar).

rahulkp220 commented 6 years ago

@crstnbr We can also add some test cases for this one.

carstenbauer commented 6 years ago

What kind of test do you have in mind? The unit printing is implicitly tested by the stringmime tests.

carstenbauer commented 6 years ago

Ok, I guess I can write some very basic ones.

rahulkp220 commented 6 years ago

@crstnbr Yup, just the basic will work. Wanted to make sure we do have these tested out :)

carstenbauer commented 6 years ago

I'll merge and tag a new v0.1.2 release for this if you approve the changes.

carstenbauer commented 6 years ago

Maybe we should explicitly mention that the fields are dimensionful in the Readme.md as well. Will add this and proceed afterwards.

rahulkp220 commented 6 years ago

Sure, makes sense. You can also reply to this comment here once we are good with the release.