search

JuliaPhysics / PeriodicTable.jl

Periodic Table for Julians! :fire:
Other
111 stars 26 forks source link

Why is Element mutable? #21

Closed jw3126 closed 6 years ago

jw3126 commented 6 years ago

I just realized, that Element is a mutable struct. This seems strange, is it intended?

rahulkp220 commented 6 years ago

No, it's not intended, neither the Element should be mutable. Should be changed to just struct. @crstnbr @stevengj agreed?

carstenbauer commented 6 years ago

Good catch, certainly not intended. Dropping the mutable should work without any further changes. @jw3126 wanna make a simple PR?

jw3126 commented 6 years ago

sure!