search

JuliaPhysics / PeriodicTable.jl

Periodic Table for Julians! :fire:
Other
111 stars 26 forks source link

Adds efficient isequal(), isless(), hash() and eachindex() #28

Closed NicholasWMRitchie closed 4 years ago

NicholasWMRitchie commented 4 years ago

Add an efficient isequal(...), isless(...), hash(...) for the Element struct and a eachindex(...) for the Elements struct. Tests provided.

codecov-io commented 4 years ago

Codecov Report

Merging #28 into master will increase coverage by 0.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   95.06%   95.29%   +0.23%     
==========================================
  Files           1        1              
  Lines          81       85       +4     
==========================================
+ Hits           77       81       +4     
  Misses          4        4
Impacted Files Coverage Δ
src/PeriodicTable.jl 95.29% <100%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 060c572...57f1a0f. Read the comment docs.

NicholasWMRitchie commented 4 years ago

Fixed hash...

stevengj commented 4 years ago

Thanks!