This defines == instead of isequal, because by default == falls down to ===. It caused me some problems (that are hard to reproduce) when using two different packages that both import PeriodicTable. Namely, the same elements ended up represented by two different objects, so that they where not identical according to === (nor according to == due to the automatic fallback).
Since isequal falls down to == by default, nothing should change.
I didn't add test as a failing scenario is quite hard to come with.
Kolaru
commented
1 year ago
This defines
==instead ofisequal, because by default==falls down to===. It caused me some problems (that are hard to reproduce) when using two different packages that both import PeriodicTable. Namely, the same elements ended up represented by two different objects, so that they where not identical according to===(nor according to==due to the automatic fallback).Since
isequalfalls down to==by default, nothing should change.I didn't add test as a failing scenario is quite hard to come with.