search

JuliaPhysics / PeriodicTable.jl

Periodic Table for Julians! :fire:
Other
111 stars 26 forks source link

many improvements #5

Closed stevengj closed 6 years ago

stevengj commented 6 years ago

This PR contains many improvements: fixes #1, fixes #2, and fixes #3.

It exports a global variable elements that contains the precompiled table data, and which acts as an iterable collection of Element data.

You can look up elements by name (case-insensitive) via elements["oxygen"], by symbol via elements[:O], or by number via elements[8], for example.

Each Element contains typed fields, and has pretty-printed output.

rahulkp220 commented 6 years ago

Although this is a bit offtopic, Julia builds for OSx takes way more time. I am not sure if that's the case with everyone or its just Travis CI

codecov-io commented 6 years ago

Codecov Report

Merging #5 into master will decrease coverage by 52.02%. The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #5       +/-   ##
==========================================
- Coverage   61.11%   9.09%   -52.03%     
==========================================
  Files           1       1               
  Lines          18      55       +37     
==========================================
- Hits           11       5        -6     
- Misses          7      50       +43
Impacted Files Coverage Δ
src/PeriodicTable.jl 9.09% <9.09%> (-52.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ec72ad...3902e84. Read the comment docs.

rahulkp220 commented 6 years ago

@stevengj I am humbled to have your code added to my repo. Thank you for the time given. 🙂