search

JuliaPhysics / PeriodicTable.jl

Periodic Table for Julians! :fire:
Other
111 stars 26 forks source link

more tests #8

Closed stevengj closed 6 years ago

stevengj commented 6 years ago

This PR mostly just adds more tests for the functions added in #5.

The only new feature is that it adds a getindex method for an array, so you can do e.g.

julia> elements[1:8]
8-element Array{PeriodicTable.Element,1}:
 Element(Hydrogen) 
 Element(Helium)   
 Element(Lithium)  
 Element(Beryllium)
 Element(Boron)    
 Element(Carbon)   
 Element(Nitrogen) 
 Element(Oxygen)
rahulkp220 commented 6 years ago

This is super awesome!

codecov-io commented 6 years ago

Codecov Report

Merging #8 into master will increase coverage by 71.26%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage    9.09%   80.35%   +71.26%     
===========================================
  Files           1        1               
  Lines          55       56        +1     
===========================================
+ Hits            5       45       +40     
+ Misses         50       11       -39
Impacted Files Coverage Δ
src/PeriodicTable.jl 80.35% <100%> (+71.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e455e9...d86ae8f. Read the comment docs.