JuliaPlots / MakieGallery.jl

Documentation and Example Gallery for Makie
http://makie.juliaplots.org/dev
Other
47 stars 27 forks source link

Various warnings and error running tests on Mac Catalina #205

Closed jandyman closed 4 years ago

jandyman commented 4 years ago

In case it is helpful, I'm attaching the output of testing the Makie package on MacOS catalina. There are various errors and warnings.

TestingMakie.txt

asinghvi17 commented 4 years ago

Could you try this on the latest master of MakieGallery, AbstractPlotting and GLMakie? I think these warnings should already have been fixed there (though I could be mistaken).

You can get the master branches by running this snippet of code in the REPL:

]add MakieGallery#master AbstractPlotting#master GLMakie#master
jandyman commented 4 years ago

I followed the instructions above. There are fewer errors, I've attached the output TestingMakie.txt

asinghvi17 commented 4 years ago

Could you post the images at $(dirname(pathof(MakieGallery)))/../test/tested_different/isorange,_isovalue?

they should be in the test/tested_different folder of the MakieGallery repo. That's the only concerning failure, since we're now seeing this across multiple machines, but not on CI (cc @SimonDanisch here, is there something different on the CI setup?).

The rest of the warnings are more or less intended, and the result should be unaffected.

Thanks a lot!

asinghvi17 commented 4 years ago

For reference, we get these warnings on CI, and the images are generated essentially correctly. These weren't in the log above, but the example seems to have failed silently.

Running isorange,_isovalue
 ┌ Warning: OpenGL call to glUniform1i, with arguments: ("5", "3")
 │                 Failed with error: GL_INVALID_OPERATION.
 └ @ ModernGL /builds/JuliaGPU/MakieGallery-jl/.julia/packages/ModernGL/rVuW2/src/functionloading.jl:22
 ┌ Warning: OpenGL call to glUniform1i, with arguments: ("5", "3")
 │                 Failed with error: GL_INVALID_OPERATION.
 └ @ ModernGL /builds/JuliaGPU/MakieGallery-jl/.julia/packages/ModernGL/rVuW2/src/functionloading.jl:22
┌ Warning: OpenGL call to glUniform3fv, with arguments: ("7", "1", "Float32[0.25, 1.0, 3.0]")
 │                 Failed with error: GL_INVALID_OPERATION.
 └ @ ModernGL /builds/JuliaGPU/MakieGallery-jl/.julia/packages/ModernGL/rVuW2/src/functionloading.jl:22
 ┌ Warning: OpenGL call to glUniform1i, with arguments: ("5", "3")
 │                 Failed with error: GL_INVALID_OPERATION.
 └ @ ModernGL /builds/JuliaGPU/MakieGallery-jl/.julia/packages/ModernGL/rVuW2/src/functionloading.jl:22
┌ Warning: OpenGL call to glUniform3fv, with arguments: ("7", "1", "Float32[0.25, 1.0, 3.0]")
 │                 Failed with error: GL_INVALID_OPERATION.
 └ @ ModernGL /builds/JuliaGPU/MakieGallery-jl/.julia/packages/ModernGL/rVuW2/src/functionloading.jl:22

This is the example: http://juliaplots.org/MakieReferenceImages/gallery/isorange,_isovalue/

jandyman commented 4 years ago

Could you post the images at $(dirname(pathof(MakieGallery)))/../test/tested_different/isorange,_isovalue?

they should be in the test/tested_different folder of the MakieGallery repo. That's the only concerning failure, since we're now seeing this across multiple machines, but not on CI (cc @SimonDanisch here, is there something different on the CI setup?).

The rest of the warnings are more or less intended, and the result should be unaffected.

Thanks a lot!

I'd be happy to, but I'm not sure where I would evaluate that expression. It doesn't appear to be a unix shell command or a Julia REPL command. Forgive me, I'm new to Atom and Julia.

asinghvi17 commented 4 years ago

In the Julia REPL, you can probably just do something like:

using MakieGallery

;open $(dirname(pathof(MakieGallery)))/../test/tested_different/

Here, the ; at the start puts the REPL into "shell mode", which essentially mimics the system shell (with some limitations).

The command will open a Finder window in the tested_different directory.

jandyman commented 4 years ago

It doesn't look like MakieGallery was even installed. I just installed Makie and MakieLayout, per instructions.

asinghvi17 commented 4 years ago

You should still have it installed if you executed this snippet:

]add MakieGallery#master AbstractPlotting#master GLMakie#master

and even if not, it would have been downloaded as a test dependency of Makie. In that case, could you poke around in ~/.julia/packages/MakieGallery/?

jandyman commented 4 years ago

oops, I assumed that MakieGallery was not installed because of this:

julia> Using MakieGallery ERROR: syntax: extra token "MakieGallery" after end of expression

list of files in ~/.julia/packages/MakieGallery/ is attached filelist.txt

jandyman commented 4 years ago

Just noticed I accidentally capitalized "Using".

But now I get this:

shell> ;open $(dirname(pathof(MakieGallery)))/../test/tested_different/ zsh:1: command not found: ;open

But I sent the file list, so it probably doesn't matter

asinghvi17 commented 4 years ago

Oh, my mistake - I'd thought you were testing MakieGallery, not Makie. Could you snoop around in ~/.julia/packages/Makie for a test/tested_different folder?

jandyman commented 4 years ago

ref_image test_image

asinghvi17 commented 4 years ago

Ahh, there's the problem. This happens on my system as well - I'll try to debug the cause today or tomorrow. Thanks for the report!

jandyman commented 4 years ago

You are welcome. This looks like a great package so I'm happy to help.

asinghvi17 commented 4 years ago

I think we have found a solution to the isorange problem, it should be merged into AbstractPlotting in the next week or so. Thanks for all the help, feel free to ask more questions if you need to!