search

JuliaPlots / PlotlyJS.jl

Julia library for plotting with plotly.js
Other
420 stars 78 forks source link

Switch to Julia Artifacts for JS dependencies #358

Closed thomasjm closed 3 years ago

thomasjm commented 3 years ago

This resolves #334 .

I ran the tests and they all passed + the test plots visually looked good.

sglyon commented 3 years ago

Thank you!

thomasjm commented 3 years ago

My pleasure @sglyon .

One note about how you might want to manage the deployments going forward: you'll notice that I made a GitHub release to contain the tarball with the necessary files and pointed Artifacts.toml to it:

https://github.com/JuliaPlots/PlotlyJS.jl/blob/8210092521df3c8953df75b284ab77e35c4ca994/Artifacts.toml#L6

It's currently pointed at the release I made in my fork, but you may want to upload your own tarball and point it there next time you cut a release. Then, going forward, you can continue to upload tarballs along with releases whenever you make new ones.

You might also want to double-check that everything still works correctly, I think I did it right but this was my first experience with the new artifacts system :)

thomasjm commented 3 years ago

Oh and one other thing -- deps/generate_artifacts.jl is out of date, sorry. I used it in the original version but I ended up changing Artifacts.toml by hand. You should probably just delete that file. Or update it to generate the desired tarball (i.e. pull the most recent plotly.js release tarball, extract the 2 necessary files from it and tar them up). Thanks!