search

JuliaPlots / PlotlyJS.jl

Julia library for plotting with plotly.js
Other
418 stars 77 forks source link

Remove savefig import from PlotlyBase #400

Closed t-bltg closed 3 years ago

t-bltg commented 3 years ago

Reference: https://github.com/sglyon/PlotlyBase.jl/pull/58

https://github.com/JuliaPlots/Plots.jl/issues/3703

sglyon commented 3 years ago

Thanks for submitting this. I just corrected this in a recent commit: https://github.com/JuliaPlots/PlotlyJS.jl/commit/d0792bbd6266843becff45ee276335cc3cf5f969

t-bltg commented 3 years ago

This breaks the Plots/backends/plotlyjs.jl in many ways.

Is it possible to restore savefig for SyncPlots ?

sglyon commented 3 years ago

Yep -- just released 0.18.2 which restores it. The lack of savefig for SyncPlot was a mistake on my part :(

I fixed the issue and added to the test suite so we shouldn't see more breaks