search

JuliaPlots / PlotlyJS.jl

Julia library for plotting with plotly.js
Other
422 stars 78 forks source link

Fix precompilation of packages depending on PlotlyJS #469

Closed Liozou closed 12 months ago

Liozou commented 1 year ago

Starting from Julia v1.10, using PlotlyJS.jl as a dependency of any other package causes the precompilation of this other package to be stuck, as explained in https://github.com/JuliaLang/julia/issues/50505. This PR fixes that.

The root cause of the issue was https://github.com/JuliaLang/julia/issues/48506. To be honest, I'm not sure I understand why the behavior of the __init__ function of PlotlyJS should livelock the precompilation of other packages... but I was inspired by https://github.com/JuliaDebug/Cthulhu.jl/pull/343/files and https://github.com/JuliaImages/ImageView.jl/pull/279/files, which targeted similar issues, for this PR.

beorostica commented 1 year ago

I'm excited for this pull request to be merged. This will be very useful for Koma MRI simulator