InspectDR meta-issue - Githubissues

JuliaPlots / Plots.jl

Powerful convenience for Julia visualizations and data analysis

https://docs.juliaplots.org

Other

1.84k stars 355 forks source link

InspectDR meta-issue #890

Open mkborregaard opened 7 years ago

mkborregaard commented 7 years ago

This is an issue to report issues arising with the inspectdr backend in one place. cc @ma-laforge .

[ ] the yflip attribute (and xflip) is not supported.

ma-laforge commented 7 years ago

There are quite a few features that InspectDR does not yet support. This is why I commented-out the :flip property of _inspectdr_attr:

const _inspectdr_attr = merge_with_base_supported([
#...
    :guide, :lims, :scale, #:ticks, :flip, :rotation,
#...
])

See: https://github.com/JuliaPlots/Plots.jl/blob/master/src/backends/inspectdr.jl#L32

Questions

Am I not de-activating the proper attribute?
Is this issue simply keeping track of features that are missing from the InspectDR backend?
Or are you saying that you would prefer using InspectDR for some of your own work, but this missing feature is keeping you from switching over from another backend?

I ask because I might be willing to add functionnality to InspectDR, depending on the amount of user interest, and the effort required in in its implementation.

FYI: Implementing x/y flip might require a few small architectural changes - given that InspectDR has an interactive mouse-controlled GUI.

mkborregaard commented 7 years ago

Thanks for the willingness. This was just to keep track of features that were missing but assumed elsewhere in Plots. The yflip attribute is used by the spy recipe in Plots itself. So no, yes, and no to your questions :-) This is part of making inspectdr a little more visible. It now appears in the documentation (experimentally, I think it should have the same visibility as glvisualize which isn't currently on there), so I thought it should also have its own issue. However, how you develop the backend is entirely up to you and your ambitions with it :-)

ma-laforge commented 7 years ago

Good to know. I do have one more question, though:

@ma-laforge: Am I not de-activating the proper attribute? @mkborregaard: [...]no[...]

Are you saying there is another "attribute" I should be disabling - or simply that there is no way to actually "de-activate" the x/yflip functionality from a backend.

mkborregaard commented 7 years ago

I think you're doing it right, sorry if it was obscure.

rafaqz commented 7 years ago

Can we remove this warning? InspectDR not known to be compatible with current version of Plots.jl.

It does seem to be compatible.

mkborregaard commented 7 years ago

yes, good idea.

ma-laforge commented 7 years ago

Sorry about that... That problem is on the InspectDR side - not Plots.jl.

I needed to re-tag a new version of InspectDR to get rid of this warning. InspectDR keeps a table of known compatible versions of Plots.jl so that the user does not get confused too much when I make a breaking change in InspectDR's API.

Sadly, I forgot to re-tag a new version of InspectDR the last time Plots.jl released a "numbered" (tagged) version that matches the newest API.

ma-laforge commented 6 years ago

Created an issue for the problem raised by @rafaqz: https://github.com/ma-laforge/InspectDR.jl/issues/13

...But this does not affect the original issue from this thread.