search

JuliaPlots / RecipesPipeline.jl

Utilities for processing recipes
http://juliaplots.org/RecipesPipeline.jl/dev/
MIT License
17 stars 17 forks source link

more friendly error when x,y shape mis-match #65

Closed Moelf closed 4 years ago

Moelf commented 4 years ago

fix https://github.com/JuliaPlots/Plots.jl/issues/3048

julia> plot( rand(5), rand(1,5) )
ERROR: Expects 5 elements in each col of y, found 1.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] _compute_xyz(::Array{Float64,1}, ::Array{Float64,1}, ::Nothing) at /home/akako/.julia/dev/RecipesPipeline/src/series.jl:97
daschw commented 4 years ago

Nice, did you run the Plots test suite with this?

Moelf commented 4 years ago

good catch, let's not touch it if z exists, there are some weird heatmap-like plot in pgfplots. btw, how do we run CI on PR here?

BeastyBlacksmith commented 4 years ago

The Plots tests run automatically

daschw commented 4 years ago

Really? I don't think we run the Plots tests here.

BeastyBlacksmith commented 4 years ago

They run on travis and only latest stable on linux: https://travis-ci.com/github/JuliaPlots/RecipesPipeline.jl/jobs/397493394

daschw commented 4 years ago

oh, nice