refine friendly error - Githubissues

JuliaPlots / RecipesPipeline.jl

Utilities for processing recipes

http://juliaplots.org/RecipesPipeline.jl/dev/

MIT License

17 stars 17 forks source link

refine friendly error #75

Closed Moelf closed 3 years ago

Moelf commented 3 years ago

fix https://github.com/JuliaPlots/RecipesPipeline.jl/issues/74

@oschulz can you check your histogram still works? The old hack wasn't ideal since users must be wrong by more than 1 in difference to get the warning, I thought it was too inconsistent.

oschulz commented 3 years ago

Thanks for the head-up @Moelf - seems to work fine!

So now the check is only run if (x isa AbstractVector) && (y isa AbstractMatrix) ?

Moelf commented 3 years ago

@oschulz that's right, I'm not confident in covering all weird cases and not over-error

oschulz commented 3 years ago

Good to merge from my side.