search

JuliaPlots / RecipesPipeline.jl

Utilities for processing recipes
http://juliaplots.org/RecipesPipeline.jl/dev/
MIT License
17 stars 17 forks source link

Reliance on error throwing in normal execution causes bad performance #93

Closed BioTurboNick closed 3 years ago

BioTurboNick commented 3 years ago

I'm looking into what's slowing down the plotting of a ~3300 shapes for a map, and on profiling found that much of the samples were coming from _process_plotrecipe.

I found out that it is throwing 21756 exceptions, swallowing them, and calling some fallback code.

Commenting out this entire section and just using the fallback method cut execution time in half.

BioTurboNick commented 3 years ago

(The 20,000 might be the accumulated result of several @btime runs, but point remains)

BioTurboNick commented 3 years ago

Issue won't fully be resolved until Plots.jl PR is done, so I'll keep open until then.