JuliaPlots / StatsPlots.jl

Statistical plotting recipes for Plots.jl
Other
436 stars 88 forks source link

Bugs in `cornerplot` and `corrplot` #538

Closed torfjelde closed 11 months ago

torfjelde commented 1 year ago

corrplot and cornerplot doesn't seem to work as described in the README:

julia> using DataFrames, IndexedTables, StatsPlots

julia> df = DataFrame(a = 1:10, b = 10 .* rand(10), c = 10 .* rand(10));

julia> @df df corrplot([:a, :b])
ERROR: MethodError: no method matching AbstractFloat(::Type{Vector{Float64}})

Closest candidates are:
  (::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number}
   @ Base char.jl:50
  (::Type{T})(::Base.TwicePrecision) where T<:Number
   @ Base twiceprecision.jl:266
  (::Type{T})(::Complex) where T<:Real
   @ Base complex.jl:44
  ...

Stacktrace:
  [1] float(x::Type)
    @ Base ./float.jl:294
  [2] cor(x::Vector{Vector{Float64}})
    @ Statistics ~/.julia/juliaup/julia-1.9.0+0.x64.linux.gnu/share/julia/stdlib/v1.9/Statistics/src/Statistics.jl:722
  [3] macro expansion
    @ ~/.julia/packages/StatsPlots/vq5FV/src/corrplot.jl:45 [inlined]
  [4] apply_recipe(plotattributes::AbstractDict{Symbol, Any}, cp::StatsPlots.CorrPlot)
    @ StatsPlots ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:300
  [5] _process_userrecipes!(plt::Any, plotattributes::Any, args::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/BGM3l/src/user_recipe.jl:38
  [6] recipe_pipeline!(plt::Any, plotattributes::Any, args::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/BGM3l/src/RecipesPipeline.jl:72
  [7] _plot!(plt::Plots.Plot, plotattributes::Any, args::Any)
    @ Plots ~/.julia/packages/Plots/esM5q/src/plot.jl:223
  [8] #plot#188
    @ ~/.julia/packages/Plots/esM5q/src/plot.jl:102 [inlined]
  [9] plot
    @ ~/.julia/packages/Plots/esM5q/src/plot.jl:93 [inlined]
 [10] #corrplot#41
    @ ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:380 [inlined]
 [11] corrplot(args::Vector{Vector{Float64}})
    @ StatsPlots ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:380
 [12] add_label(argnames::Vector{String}, f::Function, args::Vector{Vector{Float64}}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ StatsPlots ~/.julia/packages/StatsPlots/vq5FV/src/df.jl:181
 [13] add_label(argnames::Vector{String}, f::Function, args::Vector{Vector{Float64}})
    @ StatsPlots ~/.julia/packages/StatsPlots/vq5FV/src/df.jl:167
 [14] (::var"#5#6")(296::DataFrame)
    @ Main ./none:0
 [15] top-level scope
    @ REPL[10]:1

julia> @df df cornerplot([:a, :b])
ERROR: MethodError: no method matching AbstractFloat(::Type{Vector{Float64}})

Closest candidates are:
  (::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number}
   @ Base char.jl:50
  (::Type{T})(::Base.TwicePrecision) where T<:Number
   @ Base twiceprecision.jl:266
  (::Type{T})(::Complex) where T<:Real
   @ Base complex.jl:44
  ...

Stacktrace:
  [1] float(x::Type)
    @ Base ./float.jl:294
  [2] cor(x::Vector{Vector{Float64}})
    @ Statistics ~/.julia/juliaup/julia-1.9.0+0.x64.linux.gnu/share/julia/stdlib/v1.9/Statistics/src/Statistics.jl:722
  [3] macro expansion
    @ ~/.julia/packages/StatsPlots/vq5FV/src/cornerplot.jl:7 [inlined]
  [4] apply_recipe(plotattributes::AbstractDict{Symbol, Any}, cp::StatsPlots.CornerPlot)
    @ StatsPlots ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:300
  [5] _process_userrecipes!(plt::Any, plotattributes::Any, args::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/BGM3l/src/user_recipe.jl:38
  [6] recipe_pipeline!(plt::Any, plotattributes::Any, args::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/BGM3l/src/RecipesPipeline.jl:72
  [7] _plot!(plt::Plots.Plot, plotattributes::Any, args::Any)
    @ Plots ~/.julia/packages/Plots/esM5q/src/plot.jl:223
  [8] #plot#188
    @ ~/.julia/packages/Plots/esM5q/src/plot.jl:102 [inlined]
  [9] plot
    @ ~/.julia/packages/Plots/esM5q/src/plot.jl:93 [inlined]
 [10] #cornerplot#56
    @ ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:380 [inlined]
 [11] cornerplot(args::Vector{Vector{Float64}})
    @ StatsPlots ~/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:380
 [12] add_label(argnames::Vector{String}, f::Function, args::Vector{Vector{Float64}}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ StatsPlots ~/.julia/packages/StatsPlots/vq5FV/src/df.jl:181
 [13] add_label(argnames::Vector{String}, f::Function, args::Vector{Vector{Float64}})
    @ StatsPlots ~/.julia/packages/StatsPlots/vq5FV/src/df.jl:167
 [14] (::var"#7#8")(300::DataFrame)
    @ Main ./none:0
 [15] top-level scope
    @ REPL[11]:1

One immediate fix is to overload to_corrplot_matrix and to_cornerplot_matrix for AbstractVector{<:AbstractVector{<:Real}}, but given that this is an example in the README, this doesn't seem like it should be necessary?

Has something changed in Plots maybe? As in, it now expects a matrix rather than a vector of vectors?

Deps ```julia (jl_Jg2gEW) pkg> st --manifest Status `/tmp/jl_Jg2gEW/Manifest.toml` [621f4979] AbstractFFTs v1.3.1 [1520ce14] AbstractTrees v0.4.4 [79e6a3ab] Adapt v3.6.2 [7d9fca2a] Arpack v0.5.4 [13072b0f] AxisAlgorithms v1.0.1 [d1d4a3ce] BitFlags v0.1.7 [49dc2e85] Calculus v0.5.1 [d360d2e6] ChainRulesCore v1.16.0 [aaaa29a8] Clustering v0.15.2 [944b1d66] CodecZlib v0.7.1 [35d6a980] ColorSchemes v3.21.0 [3da002f7] ColorTypes v0.11.4 [c3611d14] ColorVectorSpace v0.9.10 [5ae59095] Colors v0.12.10 [34da2185] Compat v4.6.1 [f0e56b4a] ConcurrentUtilities v2.2.0 [d38c429a] Contour v0.6.2 [a8cc5b0e] Crayons v4.1.1 [9a962f9c] DataAPI v1.15.0 [a93c6f00] DataFrames v1.5.0 [864edb3b] DataStructures v0.18.13 [e2d170a0] DataValueInterfaces v1.0.0 [e7dc6d0d] DataValues v0.4.13 [8bb1440f] DelimitedFiles v1.9.1 [b4f34e82] Distances v0.10.8 [31c24e10] Distributions v0.25.91 [ffbed154] DocStringExtensions v0.9.3 [fa6b7ba4] DualNumbers v0.6.8 [c87230d0] FFMPEG v0.4.1 [7a1cc6ca] FFTW v1.6.0 [1a297f60] FillArrays v1.0.0 [53c48c17] FixedPointNumbers v0.8.4 [59287772] Formatting v0.4.2 [28b8d3ca] GR v0.72.4 [42e2da0e] Grisu v1.0.2 [cd3eb016] HTTP v1.9.4 [34004b35] HypergeometricFunctions v0.3.16 [6deec6e2] IndexedTables v1.0.0 [842dd82b] InlineStrings v1.4.0 [a98d9a8b] Interpolations v0.14.7 [41ab1584] InvertedIndices v1.3.0 [92d709cd] IrrationalConstants v0.2.2 [82899510] IteratorInterfaceExtensions v1.0.0 [1019f520] JLFzf v0.1.5 [692b3bcd] JLLWrappers v1.4.1 [682c06a0] JSON v0.21.4 [5ab0869b] KernelDensity v0.6.7 [b964fa9f] LaTeXStrings v1.3.0 [23fbe1c1] Latexify v0.16.0 [2ab3a3ac] LogExpFunctions v0.3.23 [e6f89c97] LoggingExtras v1.0.0 [1914dd2f] MacroTools v0.5.10 [739be429] MbedTLS v1.1.7 [442fdcdd] Measures v0.3.2 [e1d29d7a] Missings v1.1.0 [6f286f6a] MultivariateStats v0.10.2 [77ba4419] NaNMath v1.0.2 [b8a86587] NearestNeighbors v0.4.13 [510215fc] Observables v0.5.4 [6fe1bfb0] OffsetArrays v1.12.9 [925886fa] OnlineStatsBase v1.6.0 [4d8831e6] OpenSSL v1.4.1 [bac558e1] OrderedCollections v1.6.0 [90014a1f] PDMats v0.11.17 [69de0a69] Parsers v2.5.9 [b98c9c47] Pipe v1.3.0 [ccf2f8ad] PlotThemes v3.1.0 [995b91a9] PlotUtils v1.3.5 [91a5bcdd] Plots v1.38.11 [2dfb63ee] PooledArrays v1.4.2 [aea7be01] PrecompileTools v1.1.1 [21216c6a] Preferences v1.4.0 [08abe8d2] PrettyTables v2.2.4 [1fd47b50] QuadGK v2.8.2 [c84ed2f1] Ratios v0.4.4 [3cdcf5f2] RecipesBase v1.3.4 [01d81517] RecipesPipeline v0.6.12 [189a3867] Reexport v1.2.2 [05181044] RelocatableFolders v1.0.0 [ae029012] Requires v1.3.0 [79098fc4] Rmath v0.7.1 [6c6a2e73] Scratch v1.2.0 [91c51154] SentinelArrays v1.3.18 [992d4aef] Showoff v1.0.3 [777ac1f9] SimpleBufferStream v1.1.0 [66db9d55] SnoopPrecompile v1.0.3 [a2af1166] SortingAlgorithms v1.1.0 [276daf66] SpecialFunctions v2.2.0 [90137ffa] StaticArrays v1.5.25 [1e83bf80] StaticArraysCore v1.4.0 [82ae8749] StatsAPI v1.6.0 ⌅ [2913bbd2] StatsBase v0.33.21 [4c63d2b9] StatsFuns v1.3.0 [f3b207a7] StatsPlots v0.15.5 [892a3eda] StringManipulation v0.3.0 ⌅ [09ab397b] StructArrays v0.4.2 [ab02a1b2] TableOperations v1.2.0 [3783bdb8] TableTraits v1.0.1 [382cd787] TableTraitsUtils v1.0.2 [bd369af6] Tables v1.10.1 [62fd8b95] TensorCore v0.1.1 [3bb67fe8] TranscodingStreams v0.9.13 [5c2747f8] URIs v1.4.2 [1cfade01] UnicodeFun v0.4.1 [41fe7b60] Unzip v0.2.0 ⌅ [ea10d353] WeakRefStrings v0.6.2 [cc8bc4a8] Widgets v0.6.6 [efce3f68] WoodburyMatrices v0.5.5 ⌅ [68821587] Arpack_jll v3.5.1+1 [6e34b625] Bzip2_jll v1.0.8+0 [83423d85] Cairo_jll v1.16.1+1 [2e619515] Expat_jll v2.4.8+0 [b22a6f82] FFMPEG_jll v4.4.2+2 [f5851436] FFTW_jll v3.3.10+0 [a3f928ae] Fontconfig_jll v2.13.93+0 [d7e528f0] FreeType2_jll v2.10.4+0 [559328eb] FriBidi_jll v1.0.10+0 [0656b61e] GLFW_jll v3.3.8+0 [d2c73de3] GR_jll v0.72.4+0 [78b55507] Gettext_jll v0.21.0+0 [7746bdde] Glib_jll v2.74.0+2 [3b182d85] Graphite2_jll v1.3.14+0 [2e76f6c2] HarfBuzz_jll v2.8.1+1 [1d5cc7b8] IntelOpenMP_jll v2023.1.0+0 [aacddb02] JpegTurbo_jll v2.1.91+0 [c1c5ebd0] LAME_jll v3.100.1+0 [88015f11] LERC_jll v3.0.0+1 [dd4b983a] LZO_jll v2.10.1+0 ⌅ [e9f186c6] Libffi_jll v3.2.2+1 [d4300ac3] Libgcrypt_jll v1.8.7+0 [7e76a0d4] Libglvnd_jll v1.6.0+0 [7add5ba3] Libgpg_error_jll v1.42.0+0 [94ce4f54] Libiconv_jll v1.16.1+2 [4b2f31a3] Libmount_jll v2.35.0+0 [89763e89] Libtiff_jll v4.4.0+0 [38a345b3] Libuuid_jll v2.36.0+0 ⌅ [856f044c] MKL_jll v2022.2.0+0 [e7412a2a] Ogg_jll v1.3.5+1 ⌅ [458c3c95] OpenSSL_jll v1.1.20+0 [efe28fd5] OpenSpecFun_jll v0.5.5+0 [91d4177d] Opus_jll v1.3.2+0 [30392449] Pixman_jll v0.40.1+0 [ea2cea3b] Qt5Base_jll v5.15.3+2 [f50d1b31] Rmath_jll v0.4.0+0 [a2964d1f] Wayland_jll v1.21.0+0 [2381bf8a] Wayland_protocols_jll v1.25.0+0 [02c8fc9c] XML2_jll v2.10.3+0 [aed1982a] XSLT_jll v1.1.34+0 [4f6342f7] Xorg_libX11_jll v1.6.9+4 [0c0b7dd1] Xorg_libXau_jll v1.0.9+4 [935fb764] Xorg_libXcursor_jll v1.2.0+4 [a3789734] Xorg_libXdmcp_jll v1.1.3+4 [1082639a] Xorg_libXext_jll v1.3.4+4 [d091e8ba] Xorg_libXfixes_jll v5.0.3+4 [a51aa0fd] Xorg_libXi_jll v1.7.10+4 [d1454406] Xorg_libXinerama_jll v1.1.4+4 [ec84b674] Xorg_libXrandr_jll v1.5.2+4 [ea2f1a96] Xorg_libXrender_jll v0.9.10+4 [14d82f49] Xorg_libpthread_stubs_jll v0.1.0+3 [c7cfdc94] Xorg_libxcb_jll v1.13.0+3 [cc61e674] Xorg_libxkbfile_jll v1.1.0+4 [12413925] Xorg_xcb_util_image_jll v0.4.0+1 [2def613f] Xorg_xcb_util_jll v0.4.0+1 [975044d2] Xorg_xcb_util_keysyms_jll v0.4.0+1 [0d47668e] Xorg_xcb_util_renderutil_jll v0.3.9+1 [c22f9ab0] Xorg_xcb_util_wm_jll v0.4.1+1 [35661453] Xorg_xkbcomp_jll v1.4.2+4 [33bec58e] Xorg_xkeyboard_config_jll v2.27.0+4 [c5fb5394] Xorg_xtrans_jll v1.4.0+3 [3161d3a3] Zstd_jll v1.5.5+0 ⌅ [214eeab7] fzf_jll v0.29.0+0 [a4ae2306] libaom_jll v3.4.0+0 [0ac62f75] libass_jll v0.15.1+0 [f638f0a6] libfdk_aac_jll v2.0.2+0 [b53b4c65] libpng_jll v1.6.38+0 [f27f6e37] libvorbis_jll v1.3.7+1 [1270edf5] x264_jll v2021.5.5+0 [dfaa095f] x265_jll v3.5.0+0 [d8fb68d0] xkbcommon_jll v1.4.1+0 [0dad84c5] ArgTools v1.1.1 [56f22d72] Artifacts [2a0f44e3] Base64 [ade2ca70] Dates [8ba89e20] Distributed [f43a241f] Downloads v1.6.0 [7b1f6079] FileWatching [9fa8497b] Future [b77e0a4c] InteractiveUtils [4af54fe1] LazyArtifacts [b27032c2] LibCURL v0.6.3 [76f85450] LibGit2 [8f399da3] Libdl [37e2e46d] LinearAlgebra [56ddb016] Logging [d6f4376e] Markdown [a63ad114] Mmap [ca575930] NetworkOptions v1.2.0 [44cfe95a] Pkg v1.9.0 [de0858da] Printf [3fa0cd96] REPL [9a3f8284] Random [ea8e919c] SHA v0.7.0 [9e88b42a] Serialization [1a1011a3] SharedArrays [6462fe0b] Sockets [2f01184e] SparseArrays [10745b16] Statistics v1.9.0 [4607b0f0] SuiteSparse [fa267f1f] TOML v1.0.3 [a4e569a6] Tar v1.10.0 [8dfed614] Test [cf7118a7] UUIDs [4ec0a83e] Unicode [e66e0078] CompilerSupportLibraries_jll v1.0.2+0 [deac9b47] LibCURL_jll v7.84.0+0 [29816b5a] LibSSH2_jll v1.10.2+0 [c8ffd9c3] MbedTLS_jll v2.28.2+0 [14a3606d] MozillaCACerts_jll v2022.10.11 [4536629a] OpenBLAS_jll v0.3.21+4 [05823500] OpenLibm_jll v0.8.1+0 [efcefdf7] PCRE2_jll v10.42.0+0 [bea87d4a] SuiteSparse_jll v5.10.1+6 [83775a58] Zlib_jll v1.2.13+0 [8e850b90] libblastrampoline_jll v5.7.0+0 [8e850ede] nghttp2_jll v1.48.0+0 [3f19e933] p7zip_jll v17.4.0+0 ```
dpabon commented 11 months ago

You need to do

@df df corrplot([:a :b])

instead of

@df df corrplot([:a, :b])
torfjelde commented 11 months ago

Aaaah gotcha; thank you!