JuliaPluto / PlutoDesktop

Pluto.jl bundled into an easy-to-install desktop app — currently under development
MIT License
47 stars 1 forks source link

Do we need NotebookManager? #63

Open fonsp opened 1 year ago

fonsp commented 1 year ago

The docstring for NotebookManager:

/**
 * It is not possible to 'open' an already open notebook i.e.
 * a notebook that has not been shutdown by Pluto.
 *
 * This manager manages the currently
 * open notebooks and gives us ids of already open notebooks
 * so that we can directly go to the **edit** url.
 */

This is not true: you can open a file that is already open, and Pluto will just send you the ID of the already running notebook.

The Pluto server already keeps track of the list of running notebooks, and it seems error-prone to also keep track of this list in the electron process. We could:

ctrekker commented 7 months ago

There are certain features that require this list, but I'd say performing this query on-demand is the best way to go