JuliaPluto / PlutoSliderServer.jl

Web server to run just the `@bind` parts of a Pluto.jl notebook
https://computationalthinking.mit.edu/
The Unlicense
135 stars 18 forks source link

With version 0.3.12 I get 404 for all notebooks not in the root folder #88

Closed jbrea closed 2 years ago

jbrea commented 2 years ago

Recently I updated PlutoSliderServer for my course material from 0.3.11 to 0.3.12. Everything worked normally, except that after loading the notebooks they were not accessible at the usual address, e.g. https://bio322.epfl.ch/notebooks/pca.html showed me just a 404 error. The index page, however, loaded normally.

Meanwhile I went back PlutoSliderServer to 0.3.11, because I wanted to serve the pages and I couldn't figure out what was wrong.

fonsp commented 2 years ago

Thanks! We are looking into this!

fonsp commented 2 years ago

(This issue is about the situation where PlutoSliderServer is also serving the HTML files (run_directory), and you are viewing them by visiting the server's IP address directly. So this is not about the GitHub export feature.)

fonsp commented 2 years ago

This will be fixed by the upcoming Pluto 0.19.12 release! (Thanks Paul!)

Pangoraw commented 2 years ago

The actual fix is https://github.com/JuliaPluto/PlutoSliderServer.jl/pull/91, not https://github.com/fonsp/Pluto.jl/pull/2284!

fonsp commented 2 years ago

Right! This will be fixed by PlutoSliderServer 0.3.14. You don't need Pluto 0.19.12, I think.