search

JuliaPluto / PlutoSliderServer.jl

Web server to run just the `@bind` parts of a Pluto.jl notebook
https://computationalthinking.mit.edu/
The Unlicense
130 stars 17 forks source link

Fix errors since v0.19.13 #94

Closed disberd closed 1 year ago

disberd commented 1 year ago

Fixes #93

rikhuijzer commented 1 year ago

Ah this must have been introduced by https://github.com/fonsp/Pluto.jl/pull/2300 then. Specifically by:

- function Base.convert(::Type{<:Dict}, patch::ReplacePatch)
-   Dict{String,Any}("op" => "replace", "path" => patch.path, "value" => patch.value)
- end

In hindsight, it would have been better to not do https://github.com/fonsp/Pluto.jl/pull/2300 because I recently learned that it's bad for developers to be busy working around the compiler.

Anyway, the PR looks good to me. Thanks for the fix. I'll leave it up to @fonsp to merge since I'm not familiar with PlutoSliderServer.jl enough.

disberd commented 1 year ago

Yeah I noticed that the code change was related to that PR while trying to debug the error, but the fix seems likely very easy

rikhuijzer commented 1 year ago

but the fix seems likely very easy

Yeah well it involves a call to _convert which is by Julia convention a private method. Making public doesn't make really sense either because PlutoSliderServer would be the only user.

With that, I don't mean to say that there is anything wrong with this PR though! This is probably the best solution there is! The problem is in hindsight with https://github.com/fonsp/Pluto.jl/pull/2300.

fonsp commented 1 year ago

Thanks, I added https://github.com/fonsp/Pluto.jl/commit/c93b4d267f2b125088b5a618bce29e32d0153cb9 which would have caught the breaking change of https://github.com/fonsp/Pluto.jl/pull/2300