search

JuliaPluto / PlutoUI.jl

https://featured.plutojl.org/basic/plutoui.jl
The Unlicense
302 stars 55 forks source link

Fix `with_terminal()` by adding `args...` #150

Closed chunjiw closed 2 years ago

chunjiw commented 2 years ago

Such that with_terminal(dump, [1,2,3]) works

Thank you for opening a Pull Request at PlutoUI.jl!

Before contributing code

Note that your code will be Unlicensed when added to PlutoUI.jl, not MIT licensed like contributions to Pluto.jl. Take a look at our license: https://github.com/fonsp/PlutoUI.jl/blob/main/LICENSE

fonsp commented 2 years ago

Looks good! Can you add a new cell to the notebook where you run this example?

chunjiw commented 2 years ago

Yes! I just created a new pull request #151 (don't know how to change this pull request so I think it's better for me to create a new one).

Sorry for being late, I didn't turn on phone notification :)